Skip to content

Commit

Permalink
fix(release-check): avoid duplicated task
Browse files Browse the repository at this point in the history
  • Loading branch information
3cp committed Jun 20, 2019
1 parent 3f22fef commit 19f6547
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 6 deletions.
6 changes: 4 additions & 2 deletions build/tasks/release-checks/tests/generic/dotnet-run.js
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ class DotnetRunRendersPage extends Test {
onOutput(context, message) { onOutput(context, message) {
this.debug(message); this.debug(message);


if (isApplicationAvailableMessage(message)) { if (isApplicationAvailableMessage(message) && !this.isUp) {
this.isUp = true;
const url = getURL(message); const url = getURL(message);


const screenshot = new TakeScreenShotOfPage(url, path.join(context.resultOutputFolder, 'screenshot-of-dotnet-run.png')); const screenshot = new TakeScreenShotOfPage(url, path.join(context.resultOutputFolder, 'screenshot-of-dotnet-run.png'));
Expand All @@ -83,7 +84,8 @@ class DotNetRunAppLaunchesWithoutJavascriptErrors extends Test {
onOutput(message) { onOutput(message) {
this.debug(message); this.debug(message);


if (isApplicationAvailableMessage(message)) { if (isApplicationAvailableMessage(message) && !this.isUp) {
this.isUp = true;
const url = getURL(message); const url = getURL(message);


const checkJavascriptErrorsTask = new CheckForJavascriptErrors(url); const checkJavascriptErrorsTask = new CheckForJavascriptErrors(url);
Expand Down
6 changes: 4 additions & 2 deletions build/tasks/release-checks/tests/requirejs/au-run.js
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ class AuRunAppLaunchesWithoutJavascriptErrors extends Test {
onOutput(message) { onOutput(message) {
this.debug(message); this.debug(message);


if (isApplicationAvailableMessage(message)) { if (isApplicationAvailableMessage(message) && !this.isUp) {
this.isUp = true;
const url = getURL(message); const url = getURL(message);


const checkJavascriptErrorsTask = new CheckForJavascriptErrors(url); const checkJavascriptErrorsTask = new CheckForJavascriptErrors(url);
Expand All @@ -134,7 +135,8 @@ class AuRunRendersPage extends Test {
onOutput(context, message) { onOutput(context, message) {
this.debug(message); this.debug(message);


if (isApplicationAvailableMessage(message)) { if (isApplicationAvailableMessage(message) && !this.isUp) {
this.isUp = true;
const url = getURL(message); const url = getURL(message);


const screenshot = new TakeScreenShotOfPage(url, path.join(context.resultOutputFolder, 'screenshot-of-au-run.png')); const screenshot = new TakeScreenShotOfPage(url, path.join(context.resultOutputFolder, 'screenshot-of-au-run.png'));
Expand Down
6 changes: 4 additions & 2 deletions build/tasks/release-checks/tests/webpack/au-run.js
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ class AuRunAppLaunchesWithoutJavascriptErrors extends Test {
onOutput(message) { onOutput(message) {
this.debug(message); this.debug(message);


if (isApplicationAvailableMessage(message)) { if (isApplicationAvailableMessage(message) && !this.isUp) {
this.isUp = true;
const url = getURL(message); const url = getURL(message);


const checkJavascriptErrorsTask = new CheckForJavascriptErrors(url); const checkJavascriptErrorsTask = new CheckForJavascriptErrors(url);
Expand All @@ -139,7 +140,8 @@ class AuRunRendersPage extends Test {
onOutput(context, message) { onOutput(context, message) {
this.debug(message); this.debug(message);


if (isApplicationAvailableMessage(message)) { if (isApplicationAvailableMessage(message) && !this.isUp) {
this.isUp = true;
const url = getURL(message); const url = getURL(message);


const screenshot = new TakeScreenShotOfPage(url, path.join(context.resultOutputFolder, 'screenshot-of-au-run.png')); const screenshot = new TakeScreenShotOfPage(url, path.join(context.resultOutputFolder, 'screenshot-of-au-run.png'));
Expand Down

0 comments on commit 19f6547

Please sign in to comment.