Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

au run -o opens 2 chrome tabs #1129

Closed
bdelsaz opened this issue Jun 24, 2019 · 2 comments

Comments

@bdelsaz
Copy link

commented Jun 24, 2019

First of all, thank os community you for this awesome framework!

I'm submitting a bug report

  • Library Version:
    aurelia-cli v1.0.1

Environment

  • Operating System:
    Windows 10

  • Node Version:
    v10.15.3

  • NPM Version:
    6.9.0

  • Browser:
    Chrome Version 75.0.3770.100 (Official Build) (32-bit)

  • Language:
    Typescript 3.1

  • Loader/bundler:
    Webpack

Current behavior:
When running au run -o chrome opens 2 identical tabs with my aurelia project

  • What is the expected behavior?
    I expect aurelia/chrome to open 1 tab with my aurelia project

  • What is the motivation / use case for changing the behavior?
    Not a big deal but it is annoying having to close one tab every time

@3cp

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

I can reproduce the issue on Windows (not on mac). Don't know what's wrong with webpack-dev-server.

The option is directly passed to webpack-dev-server in aurelia-project/tasks/run.ts

open: project.platform.open || CLIOptions.hasFlag('open'),
@3cp

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

@shahabganji found the cause in #1132, it's a duplicated effort in cli.

shahabganji added a commit to shahabganji/cli that referenced this issue Aug 16, 2019
shahabganji added a commit to shahabganji/cli that referenced this issue Aug 26, 2019
fix(--open): resolved aurelia#1129
With --open argument the run command used to open two tabs

@3cp 3cp closed this in 4aded24 Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.