Make request available in Interceptor.response/responseError

[timbell]

Could the Interceptor.response and (especially) responseError methods be extended to include the original request? This would allow us to implement 401 handling with retry as can be done with http-client using HttpResponseMessage.requestMessage.

[bryanrsmith]

Yes, good idea!

[bryanrsmith]

I'll try to work on this soon, but in the meantime it would be a good feature for someone interested in contributing! Here's what it would probably take:

1. Modify applyInterceptors to accept an optional array of additional arguments to the interceptors. Need to change the interceptor invocation to something like successHandler && x => interceptor.successHandler(x, ...interceptorArgs).
2. Modify processResponse's parameter list to accept the response and pass it along to applyInterceptors.
3. Include result in the arguments passed to processResponse
4. Add a test or two to cover the new functionality.

[timbell]

I can have a shot at this sometime this week if you like?

[timbell]

I have prepared a branch with the changes but I don't have the rights to publish to the repository (I have just submitted the a CLA).

[EisenbergEffect]

@bryanrsmith CLA is confirmed.
@timbell You should be able to create a pull request from your branch on GitHub. Then we can review it and merge.

[timbell]

Struggling to push local changes =>

git push origin include-original-request-in-interceptor-response-callbacks
remote: Permission to aurelia/fetch-client.git denied to timbell.
fatal: unable to access 'https://github.com/aurelia/fetch-client.git/': The requested URL returned error: 403

[gheoan]

@timbell You have to first fork this repo.
Then add the fork as a remote.

git remote add fork https://github.com/timbell/fetch-client.git

Then git push fork include-original-request-in-interceptor-response-callbacks. Now you should see the 'submit pull request' button on https://github.com/timbell/fetch-client

It is common practice to git clone the fork so you have it as origin remote and if you need the forked repo you can add it as upstream remote.

[timbell]

@gheoan - thanks. I've managed to submit something now - hopefully not too wrong...

[timbell]

@bryanrsmith - sorry, I presume my commit comment closed this?
I've updated the pull request