Passing existing config to configure function #74
Labels
Comments
micro-jumbo
added a commit
to micro-jumbo/fetch-client
that referenced
this issue
Sep 27, 2016
In configure(function(config: HttpClientConfiguration)) current configuration is passed to the function. This allows us to override existing configuration without loosing its defaults and baseUrl Closes aurelia#74
|
@bryanrsmith What do you think of this? |
|
Sounds reasonable to me. I'm actually not a fan of allowing reconfiguration at all. My favorite idea for this was actually to make the configuration immutable, and instead of allowing reconfiguration we'd have a simple way to create a new instance (child instance?) whose config was based on the first instance. It would be harder to introduce undesirable side effects when a shared client is reconfigured by one consumer. I didn't get that idea fleshed out in time for release, though. Since we already allow reconfiguration I have no objection to this change :-) |
|
@EisenbergEffect @bryanrsmith |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When calling
configure(function(config))theconfigparameter should be passed with values currently configuredThe text was updated successfully, but these errors were encountered: