Skip to content

Commit

Permalink
doc(backers): a new Bronze Backer
Browse files Browse the repository at this point in the history 
Thanks CodeFirst for your generation contribution to Aurelia!
  • Loading branch information
@EisenbergEffect
EisenbergEffect committed Nov 17, 2018
1 parent c4d658f commit 01c0272
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
1 change: 1 addition & 0 deletions BACKERS.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Below you'll find a list of the wonderful people and organizations that have mad
## Bronze Sponsors

* [AmVenture](https://www.amventure.com/)
* [CodeFirst](https://www.codefirst.co.uk/)
* [Diapason](https://www.diapason-treasury.com/trms/)
* [Effectory](https://www.effectory.com/)
* [Exceptionless](https://exceptionless.com/)
Expand Down
5 changes: 0 additions & 5 deletions dist/aurelia-framework.d.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,3 @@ export * from 'aurelia-loader';
export * from 'aurelia-task-queue';
export * from 'aurelia-path';
export * from 'aurelia-pal';

/**
* The log manager.
*/
export const LogManager: typeof TheLogManager;

3 comments on commit 01c0272

@gdadon
Copy link

@gdadon gdadon commented on 01c0272 Nov 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you removed the export for LogManager?
This has caused my build to failed with error - "error TS2305: Module ''aurelia-framework'' has no exported member 'LogManager'."
can you revert it please? or supply workaround to get the LogManger back again ?

@EisenbergEffect
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies. I'll add it back. It's a tricky spot because the d.ts gnerator doesn't actually generate this, so we add it by hand for each release. Then, TSDoc, which we use to generate the API docs, gets confused by this and generates bogus data, so we have to remove it before generating docs. Basically, two separate tools both error in different ways depending on whether it's there or not. We wouldn't release without this though. I'll push the fix to master. It sounds like you are working from the master branch instead of an official release. I'd definitely recommend not doing that if you can.

@gdadon
Copy link

@gdadon gdadon commented on 01c0272 Nov 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding it back, i will change our code to work with specific branch.

Please sign in to comment.