BREAKING CHANGE chore: upgrade to i18next v21 #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though the public API for aurelia-i18n does not change, i18next in v21.x introduces breaking changes that may bring surprises for aurelia users. Hence marking this as a BREAKING CHANGE. Major changes are:
- Plural suffix changed from `_plural` to `_other`.
- Missing interpolation variables are not replaced with empty string by default and you need to set the following initialization options: `interpolation: { skipOnVariables: false }`
More details can be found here: https://www.i18next.com/misc/migration-guide#v20.x.x-to-v21.0.0.
Sayan751
changed the title
Pull Request Test Coverage Report for Build 3519b320-27db-4d28-801c-60ea939e5efa
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the public API for aurelia-i18n does not change, i18next in v21.x introduces breaking changes that may bring surprises for aurelia users. Hence marking this as a BREAKING CHANGE. Major changes are:
_pluralto_other.interpolation: { skipOnVariables: false }More details can be found here: https://www.i18next.com/misc/migration-guide#v20.x.x-to-v21.0.0.