fix: remove unnecessary inline SystemJS text plugin #51
Conversation
Both cli+bundler+systemjs and skeleton-navigation (jspm skeletons) bundle npm package systemjs-plugin-text. The previous inline text plugin in loader-default is unnecessary, and it prevents aurelia-i18n-loader from working properly with SystemJS. closes aurelia/i18n#289
|
Tested with both mentioned setups. |
|
@huochunpeng Actually, just after I merged, I realized there might be a temporary problem with this. |
|
You are right, the todo app will break, but only after you pack a new aurelia-core.min.js for it. Easy fix:
FYI, this is a better implementation of text plugin, copied from systemjs-plugin-text. System.set('text', System.newModule({
'translate': function (load) {
load.metadata.format = 'amd';
return 'define(function() {\nreturn ' + JSON.stringify(load.source) + ';\n});';
}
}));
<!DOCTYPE html>
<html>
<head>
<title>Aurelia</title>
</head>
<body aurelia-app="src/main">
<script src="scripts/system.js"></script>
<script src="scripts/text.js"></script>
<script src="scripts/config-typescript.js"></script>
<script src="scripts/aurelia-core.js"></script>
<script>
System.import('aurelia-bootstrapper');
</script>
</body>
</html> |
|
We can't generate those files really anymore or re-pack them. We're killing them off entirely since we have an official script tag build. However, the tutorial doesn't match that either. So, we're in a bit of a sticky spot now. |
|
If you don't re-pack them, it would not break. |
|
LOL I'm silly. Thanks. I'll get this in, no problem. (embarrassed) |
Both cli+bundler+systemjs and skeleton-navigation (jspm skeletons) bundle npm package systemjs-plugin-text. The previous inline text plugin in loader-default is unnecessary, and it prevents aurelia-i18n-loader from working properly with SystemJS.
closes aurelia/i18n#289