-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow route viewport to be passed by the caller #440
Comments
A few thoughts.
The main issue here is deep linking using the href attribute. This enhancement may depend upon support for optional viewports. At the moment, to accomplish this, we may have to dynamically generate a one-time usage route that is populated with the target route, target viewport, and all of the current modules for all of the currently-rendered viewports. |
separation of concerns alternate behavior (pop up window for new message w/o folder structure) can be defined with just another route using the same module IMO can be closed.. |
I'm submitting a feature request
1.1.0
Please tell us about your environment:
Operating System:
Windows 7
Node Version:
4.1.2
NPM Version:
3.5.1
JSPM OR Webpack AND Version
JSPM 0.16.15
Browser:
all
Language:
all
Current behavior:
Currently, viewports must be defined as part of the route config for a given router. Different routes can specify different viewports (or omit viewport configuration), but a viewport cannot be chosen dynamically by the caller making the navigation request.
Expected/desired behavior:
The desired behavior is to be able to specify a viewport in the
route-href
binding, like so:Alternate methods could possibly look like this:
What is the expected behavior?
Routes can be defined at a high-level to match modules to routes, while the caller can then specify where the module should be loaded.
What is the motivation / use case for changing the behavior?
The use case is a viewport in a main application that can be reopened in a new window. For instance, the "compose email" window in Gmail could be implemented as a separate viewport in a larger app, with a link to a generic "compose" module. Clicking a "New Email" link within the larger application would open the "compose" module within the target viewport, but a user could open the same module in a new window by opening a browser pointed directly to the route.
The text was updated successfully, but these errors were encountered: