Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(navigation-plan): add query string from redirect instruction #643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MartyBoi
Copy link

@MartyBoi MartyBoi commented Jul 1, 2019

@CLAassistant
Copy link

CLAassistant commented Jul 1, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bigopon
Copy link
Member

bigopon commented Jul 1, 2019

@MartyBoi It doesn't seem we can simply append the redirect location. There're cases where things would override each other, and there is an issue with redirect with dynamic part in the URL too.

Would need @davismj to chime in

@rmja
Copy link

rmja commented Feb 7, 2022

This seems like a reasonable and non breaking change. Could it be merged?

rmja added a commit to rmja/router that referenced this pull request Feb 7, 2022
@rmja
Copy link

rmja commented Apr 5, 2022

I would really appreciate if a maintainer would look at this PR. It seems really simple and I have used it for a long time now in a big app without any issues.
ping @bigopon

@bigopon
Copy link
Member

bigopon commented Apr 5, 2022

@rmja there' concerns stated in my comments above #643 (comment) and the linked issues.
I don't think we can simply merge this yet. And for the very least, we should have a failing test, can you help with that? I can then help proceed this forward faster.

@rmja
Copy link

rmja commented Apr 5, 2022

@bigopon Thanks for getting back. There is a very simple example in the issue #667.
Basically, if a route is configured like { route: "does-not-work", redirect: "/dashboard?autoselect=true"; }, then the parameter autoselect is not passed on as a parameter to dashboard.

@rmja
Copy link

rmja commented Aug 17, 2023

How do we proceed with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants