Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(view-engine): define metadata for SlotCustomAttribute #567

Conversation

StrahilKazlachev
Copy link
Contributor

fix #566
@EisenbergEffect I have some concerns about the fix, since ViewEngine creates and initializes the behavior instance:

  • currently the relation is au-slot behavior instance per ViewEngine instance.
  • defining the metadata changes this - now it's on the class SlotCustomAttribute.
    • is it supported use case to have more than one instance of ViewEngine in an app(enhance)?
    • is it supported use case to have more than one apps running in parallel?

@EisenbergEffect
Copy link
Contributor

I think this will work. I'm going to move the first three lines out of the instance so the same behavior would be shared. Init is guarded so that it's only run once.

@EisenbergEffect EisenbergEffect merged commit c53f5cf into aurelia:master Oct 14, 2017
@StrahilKazlachev StrahilKazlachev deleted the fix/slot-attribute/missing-metadata branch November 19, 2017 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when having slot attribute on <slot>
2 participants