-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more renderers #2
Comments
Are you thinking about something where you just provide the class to add to parent / self / sibling and provide a different selector for each? (cover all frameworks) What about appending * or span to a specified selector if field is required as an option. e.g. First Name -> First Name* |
I'll gladely add some nice renderers, however currently it isn't possible to configure the plugin in regards to what renderer to use. Love this new lib btw. |
@Einarsson You will need to add that functionality in which would be part of the enhancement. |
We plan to get this in before this coming Tuesday so if anyone wants to take a stab I can give some guidance |
@PWKad Can you comment on my approach vs multiple renderers (which still could be done) Also you are wanting to display an aggregation of data errors by configuration? |
@PWKad I'm interested in creating a I just got it working for Is there any guidance on where to put community written |
@brandonseydel We want to have the renderer pulled in using DI from the container. This will allow using different renderers all over the place. Hope to get this in place (pulling renderer from container) ASAP. @32graham we plan to have a few renderers available by default although we aren't sure exactly how to structure it just yet. I appreciate the help with getting the paper one in place and I'll be sure to ping back here with a more long-term approach ASAP. |
@brandonseydel @32graham how does this look -
for setting up a renderer globally? You can also set it up on a per-component basis but I'm still thinking of the best way of handling this. |
Looks good @PWKad |
Fixes #2. This allows the developer to configure a new renderer to use globally. Next step is to show recommendation for how to do this at each component as well.
@Einarsson cool thanks for the feedback I've just created a branch with those changes in it if everyone likes that for now I'll merge shortly |
@PWKad As far as setting a global renderer goes this seems great. |
@PWKad I second that approach for setting the global renderer. |
Add more renderers to cover bootstrap scenarios such as a custom attribute to crawl the DOM and locate all properties that are being validated and show errors if needed.
Also would be nice to have renderers for other style frameworks as well.
The text was updated successfully, but these errors were encountered: