Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dims to Azure encoder #305

Merged
merged 14 commits into from
Jun 1, 2024
Merged

feat: add dims to Azure encoder #305

merged 14 commits into from
Jun 1, 2024

Conversation

jamescalam
Copy link
Member

@jamescalam jamescalam commented Jun 1, 2024

PR Type

documentation


Description

  • Added a reference to the Arxiv paper titled "Semantic Routing for Enhanced Performance of LLM-Assisted Intent-Based 5G Core Network Management and Orchestration" by Dimitrios Manias, Ali Chouman, and Abdallah Shami to the README.

Changes walkthrough 📝

Relevant files
Documentation
README.md
Add Arxiv paper reference to README                                           

README.md

  • Added a new reference to an Arxiv paper related to semantic routing.
  • +2/-0     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 1, 2024
    Copy link

    github-actions bot commented Jun 1, 2024

    PR Description updated to latest commit (7e92193)

    Copy link

    github-actions bot commented Jun 1, 2024

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5]

    1, because the PR is straightforward with only a documentation update involving adding a single reference to the README file.

    🧪 Relevant tests

    No

    ⚡ Possible issues

    No

    🔒 Security concerns

    No

    Code feedback:

    Copy link

    github-actions bot commented Jun 1, 2024

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Add a brief description to the new paper entry for consistency and quick reader insight

    Consider adding a brief description or a tagline for the paper by Dimitrios Manias et al.,
    similar to the entries for other papers and articles listed. This will provide readers
    with a quick insight into the content and relevance of the paper without needing to open
    the link.

    README.md [145]

    -Dimitrios Manias, Ali Chouman, Abdallah Shami, [Semantic Routing for Enhanced Performance of LLM-Assisted Intent-Based 5G Core Network Management and Orchestration](https://arxiv.org/abs/2404.15869), IEEE GlobeCom 2024
    +Dimitrios Manias, Ali Chouman, Abdallah Shami, [Semantic Routing for Enhanced Performance of LLM-Assisted Intent-Based 5G Core Network Management and Orchestration](https://arxiv.org/abs/2404.15869) - Exploring the integration of LLMs in 5G networks, IEEE GlobeCom 2024
     
    Suggestion importance[1-10]: 9

    Why: The suggestion improves the readability and consistency of the document by providing a brief description of the new paper entry, similar to other entries. This helps readers quickly understand the content and relevance of the paper.

    9

    feat: `AzureOpenAIEncoder` dimension support
    @jamescalam jamescalam changed the title feat: add arxiv paper to readme feat: add dims to Azure encoder Jun 1, 2024
    @jamescalam
    Copy link
    Member Author

    HF test failures seem to be related to HF Hub version huggingface/transformers#31019

    @jamescalam
    Copy link
    Member Author

    Cannot repro locally, given context of PR will merge and hope HF release new version with a fix soon

    @jamescalam jamescalam merged commit 82fadb5 into main Jun 1, 2024
    3 of 6 checks passed
    @jamescalam jamescalam deleted the james/azure-dims-testing branch June 1, 2024 11:05
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    documentation Improvements or additions to documentation Review effort [1-5]: 1
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    2 participants