Fix(engine): Original_storage bug fix; more tracing tests #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
added
C-bug
joshuajbouw
approved these changes
Dec 9, 2021
birchmd
force-pushed
the
geth-trace-tests
branch
from
7115772
to
123d583
Compare
Merged
artob
pushed a commit
that referenced
this pull request
Dec 10, 2021
* Feat(engine): London hard fork support (#244) * Fix(exit precompile): Address to refund in case of error is an argument (#311) * Feat(engine): Make engine parametric in storage access (#314) * Test verifying the EVM log returns the correct address (#341) * Remove sdk::current_account_id usage from engine-precompiles (#346) * Remove Default trait bound from engine IO (#342) * Remove some sdk usage from core logic (#347) * Factor out blockchain environment variable access as a trait (#349) * Factor out NEAR promise host functions into a trait (#353) * Borsh deserialized value field for call args (#351) * Refactor(eth-connector): Use Result return values instead of panicking (#355) * Gate all NEAR host functions behind the contract feature (#356) * Bump @openzeppelin/contracts from 4.3.2 to 4.3.3 in /etc/eth-contracts * Chore: Newtypes for gas (#344) * Feat(standalone): Standalone (#345) * Minor fixes to sdk refactor (#359) * Refactor(engine): Move submit logic into engine module (#366) * Feat(standalone): Storage backend (#375) * NEAR random numbers from solidity contract (#368) * Feat(standalone): EVM tracing via SputnikVM (#383) * Feat(standalone): Bootstrap storage from relayer and state snapshots (#379) * Feat(standalone): Structures and logic for keeping storage in sync with the blockchain (#382) * Feat(standalone): Capture geth-like tracing from SputnikVM events (#384) * Connector cleanup (#374) * Remove betanet * Fix(engine): original_storage bug fix; more tracing tests (#390) * Increase NEAR Gas for ft_on_transfer (#389) Co-authored-by: Andrew Bednoff <andrew.bednoff@aurora.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Evgeny Ukhanov <evgeny.ukhanov@aurora.dev> Co-authored-by: Marcelo Fornet <marcelo.fornet@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal of this PR was to add more tests for our geth tracing feature. This is accomplished, and also uncovered a bug in the engine.
The implementation of
original_storagewas incorrect in always returningNone. The original value is accessible because SputnikVM does not change storage values until after the transaction is complete (it stores intermediate writes in memory). This incorrect implementation was causing one of the example transactions I chose to check the trace of to not be replayed correctly (it was assigning the wrong gas cost to one of theSSTOREsteps because the original value was listed as missing).This PR fixed this
original_storagebug along with adding the new tracing tests.The tests also uncovered a bug in how I was interpreting the
memory_costfrom SputnikVM, and fixes that as well.Note: by simply changing the
original_storageimplementation without taking into account any backwards compatibility, it means the debug tracing of old transactions may differ slightly from what happened when they were originally executed on NEAR. Personally I think this is acceptable because debug tracing is generally most useful for recent transactions only. Therefore, this bug will have been fixed in the engine by the time anyone wants to debug a transaction and they will see consistent results.Note: fixing the
original_storagebug causes the 1inch and uniswap gas costs to increase a little. This may have cause more transactions to hit the NEAR gas limit if they were already close to it. However, I believe it still necessary to make this change because we want our EVM implementation to be as accurate as possible. Hopefully this change will not break anything because the increase is small. And if it does, the problem should be resolved relatively quickly because another wasm cost decrease is coming to mainnet soon.