feat: add possibility to use fixed gas cost (silo) #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
approved these changes
Apr 27, 2023
Karkunow
reviewed
Apr 27, 2023
mrLSD
approved these changes
May 1, 2023
vimpunk
suggested changes
May 1, 2023
vimpunk
reviewed
May 2, 2023
vimpunk
approved these changes
May 3, 2023
aleksuss
force-pushed
the
feat/aleksuss/silo
branch
from
eacd682
to
eb4195d
Compare
aleksuss
force-pushed
the
feat/aleksuss/silo
branch
from
eb4195d
to
fd05d8f
Compare
joshuajbouw
suggested changes
May 15, 2023
aleksuss
force-pushed
the
feat/aleksuss/silo
branch
from
0ed5cb3
to
664ea73
Compare
Karkunow
reviewed
May 17, 2023
Karkunow
reviewed
May 17, 2023
## Description The PR just updates release notes in the develop branch and bumps `aurora-engine` version.
# Conflicts: # CHANGES.md # Cargo.toml # engine-hashchain/src/bloom.rs # engine-hashchain/src/hashchain.rs # engine-hashchain/src/lib.rs # engine-standalone-storage/src/sync/mod.rs # engine-standalone-storage/src/sync/types.rs # engine-tests/src/tests/one_inch.rs # engine-tests/src/tests/promise_results_precompile.rs # engine-tests/src/utils/mod.rs # engine-tests/src/utils/standalone/mod.rs # engine-types/src/storage.rs # engine/src/lib.rs
# Conflicts: # engine-precompiles/src/native.rs # engine-tests/src/tests/erc20_connector.rs # engine-tests/src/utils/workspace.rs
aleksuss
force-pushed
the
feat/aleksuss/silo
branch
2 times, most recently
from
26fb92f
to
fcf4435
Compare
# Conflicts: # CHANGES.md
aleksuss
force-pushed
the
feat/aleksuss/silo
branch
from
fcf4435
to
d19f5e6
Compare
mrLSD
approved these changes
Oct 3, 2023
birchmd
reviewed
Oct 3, 2023
birchmd
approved these changes
Oct 3, 2023
karim-en
approved these changes
Oct 4, 2023
## Description The PR adds a possibility to mirror previously deployed ERC-20 contracts on the main Aurora contract. The transaction `mirror_erc20_token` is allowed in the Silo mode only. `mirror_erc20_token` accepts parameters serialised with borsh. `get(set)_erc20_metadata` accepts parameters serialised with JSON. ## Performance / NEAR gas cost considerations There are no changes in the performance/gas consumption. ## Testing The corresponding test has been added.
# Conflicts: # engine-tests/src/tests/sanity.rs # engine-tests/src/utils/mod.rs
aleksuss
added a commit
that referenced
this pull request
Oct 17, 2023
## Description The PR adds the possibility to set fixed gas costs per EVM transaction. The feature could be switched on by calling the transaction `set_fixed_gas_cost`. Also, four types of white lists have been added for applying restrictions to deploy code and submit transactions. **Additions**: The PR introduces a new feature: `ext-connector`, and two additional profiles: `mainnet-silo` and `testnet-silo`. The smart contract built with one of these profiles implies the usage of an external eth-connector. ## Performance / NEAR gas cost considerations There are insignificant gas cost increases. That is because we read from the storage fixed gas cost in the execution of the `submit` method. ## Testing The unit and integration tests which test the new logic have been added. ## How should this be reviewed <!-- Include any recommendations of areas to be careful of to ensure that the reviewers use extra attention. --> ## Additional information <!-- Include any additional information which you think should be in this PR, such as prior arts, future extensions, unresolved problems, or a TODO list which should be followed up. --> --------- Co-authored-by: Karim <karim@aurora.dev> Co-authored-by: Joshua J. Bouw <joshua@aurora.dev> Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev>
Merged
aleksuss
added a commit
that referenced
this pull request
Oct 17, 2023
## Release 3.2.0 ### Changes - Changed structure `SetEthConnectorContractAccountArgs` for setting eth connector account. It was extended with additional field: `withdraw_serialize_type` for defining serialization type for withdraw arguments by [@aleksuss]. ([#834]) - Updated rocksdb up to 0.21.0 by [@aleksuss]. ([#840]) ### Additions - Added a possibility of mirroring deployed ERC-20 contracts in the main Aurora contract in Silo mode by [@aleksuss]. ([#844]) - Allow to initialize hashchain directly with the `new` method by [@birchmd]. ([#846]) - Added a silo logic which allows to set fixed gas costs per transaction by [@aleksuss]. ([#746]) - Added a new type of transaction which allows to add full access key into account of the smart contract by [@aleksuss]. ([#847]) [#746]: #746 [#834]: #834 [#840]: #840 [#844]: #844 [#846]: #846 [#847]: #847 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: i-fix-typos <146758284+i-fix-typos@users.noreply.github.com> Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Karim <karim@aurora.dev> Co-authored-by: Joshua J. Bouw <joshua@aurora.dev> Co-authored-by: ForwardSlashBack <142098649+ForwardSlashBack@users.noreply.github.com>
aleksuss
added a commit
that referenced
this pull request
Oct 17, 2023
## Release 3.2.0 ### Changes - Changed structure `SetEthConnectorContractAccountArgs` for setting eth connector account. It was extended with additional field: `withdraw_serialize_type` for defining serialization type for withdraw arguments by [@aleksuss]. ([#834]) - Updated rocksdb up to 0.21.0 by [@aleksuss]. ([#840]) ### Additions - Added a possibility of mirroring deployed ERC-20 contracts in the main Aurora contract in Silo mode by [@aleksuss]. ([#844]) - Allow to initialize hashchain directly with the `new` method by [@birchmd]. ([#846]) - Added a silo logic which allows to set fixed gas costs per transaction by [@aleksuss]. ([#746]) - Added a new type of transaction which allows to add full access key into account of the smart contract by [@aleksuss]. ([#847]) [#746]: #746 [#834]: #834 [#840]: #840 [#844]: #844 [#846]: #846 [#847]: #847 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: i-fix-typos <146758284+i-fix-typos@users.noreply.github.com> Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Karim <karim@aurora.dev> Co-authored-by: Joshua J. Bouw <joshua@aurora.dev> Co-authored-by: ForwardSlashBack <142098649+ForwardSlashBack@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR adds the possibility to set fixed gas costs per EVM transaction. The feature could be switched on by calling the transaction
set_fixed_gas_cost. Also, four types of white lists have been added for applying restrictions to deploy code and submit transactions.Additions: The PR introduces a new feature:
ext-connector, and two additional profiles:mainnet-siloandtestnet-silo. The smart contract built with one of these profiles implies the usage of an external eth-connector.Performance / NEAR gas cost considerations
There are insignificant gas cost increases. That is because we read from the storage fixed gas cost in the execution of the
submitmethod.Testing
The unit and integration tests which test the new logic have been added.
How should this be reviewed
Additional information