Feat: Allow hashchain to be initialized with new directly #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
added
C-enhancement
aleksuss
approved these changes
Oct 4, 2023
mrLSD
approved these changes
Oct 5, 2023
aleksuss
pushed a commit
that referenced
this pull request
Oct 17, 2023
## Description For the mainnet Aurora Engine we must use the `pause_contract` + `start_hashchain` migration procedure because it is already live. However, for new silos it will be useful to have the hashchain enabled from the start. This PR adds a new optional parameter to the `new` function where an initial (genesis) hashchain value can be specified and then hashchain will be enabled on all transactions going forward. ## Performance / NEAR gas cost considerations N/A; impacts `new` only. ## Testing Tests updated to use `new` for starting the hashchain by default. Some tests still use the migration procedure to ensure that is also tested.
Merged
aleksuss
added a commit
that referenced
this pull request
Oct 17, 2023
## Release 3.2.0 ### Changes - Changed structure `SetEthConnectorContractAccountArgs` for setting eth connector account. It was extended with additional field: `withdraw_serialize_type` for defining serialization type for withdraw arguments by [@aleksuss]. ([#834]) - Updated rocksdb up to 0.21.0 by [@aleksuss]. ([#840]) ### Additions - Added a possibility of mirroring deployed ERC-20 contracts in the main Aurora contract in Silo mode by [@aleksuss]. ([#844]) - Allow to initialize hashchain directly with the `new` method by [@birchmd]. ([#846]) - Added a silo logic which allows to set fixed gas costs per transaction by [@aleksuss]. ([#746]) - Added a new type of transaction which allows to add full access key into account of the smart contract by [@aleksuss]. ([#847]) [#746]: #746 [#834]: #834 [#840]: #840 [#844]: #844 [#846]: #846 [#847]: #847 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: i-fix-typos <146758284+i-fix-typos@users.noreply.github.com> Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Karim <karim@aurora.dev> Co-authored-by: Joshua J. Bouw <joshua@aurora.dev> Co-authored-by: ForwardSlashBack <142098649+ForwardSlashBack@users.noreply.github.com>
aleksuss
added a commit
that referenced
this pull request
Oct 17, 2023
## Release 3.2.0 ### Changes - Changed structure `SetEthConnectorContractAccountArgs` for setting eth connector account. It was extended with additional field: `withdraw_serialize_type` for defining serialization type for withdraw arguments by [@aleksuss]. ([#834]) - Updated rocksdb up to 0.21.0 by [@aleksuss]. ([#840]) ### Additions - Added a possibility of mirroring deployed ERC-20 contracts in the main Aurora contract in Silo mode by [@aleksuss]. ([#844]) - Allow to initialize hashchain directly with the `new` method by [@birchmd]. ([#846]) - Added a silo logic which allows to set fixed gas costs per transaction by [@aleksuss]. ([#746]) - Added a new type of transaction which allows to add full access key into account of the smart contract by [@aleksuss]. ([#847]) [#746]: #746 [#834]: #834 [#840]: #840 [#844]: #844 [#846]: #846 [#847]: #847 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: i-fix-typos <146758284+i-fix-typos@users.noreply.github.com> Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Karim <karim@aurora.dev> Co-authored-by: Joshua J. Bouw <joshua@aurora.dev> Co-authored-by: ForwardSlashBack <142098649+ForwardSlashBack@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the mainnet Aurora Engine we must use the
pause_contract+start_hashchainmigration procedure because it is already live. However, for new silos it will be useful to have the hashchain enabled from the start. This PR adds a new optional parameter to thenewfunction where an initial (genesis) hashchain value can be specified and then hashchain will be enabled on all transactions going forward.Performance / NEAR gas cost considerations
N/A; impacts
newonly.Testing
Tests updated to use
newfor starting the hashchain by default. Some tests still use the migration procedure to ensure that is also tested.