Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(tracing): Do not panic on empty call stack #817

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

birchmd
Copy link
Member

@birchmd birchmd commented Aug 9, 2023

Description

Fixes a bug where standalone engine can crash on tracing transactions with too large contract deployment.

Testing

New regression test.

@birchmd birchmd added C-bug Category: Something isn't working. A-standalone Area: the standalone engine EVM labels Aug 9, 2023
@birchmd birchmd requested a review from aleksuss August 9, 2023 21:52
@aleksuss aleksuss added this pull request to the merge queue Aug 10, 2023
Merged via the queue into develop with commit f57df5c Aug 10, 2023
20 checks passed
@aleksuss aleksuss deleted the fix/birchmd/tracing-crash branch August 10, 2023 07:49
aleksuss pushed a commit that referenced this pull request Aug 10, 2023
## Description

Fixes a bug where standalone engine can crash on tracing transactions
with too large contract deployment.

## Testing

New regression test.
@aleksuss aleksuss mentioned this pull request Aug 10, 2023
aleksuss added a commit that referenced this pull request Aug 10, 2023
### Changes

- Added a view transaction `factory_get_wnear_address` for returning
address for the `wNEAR` ERC-20 contract by [@aleksuss]. ([#807])

### Fixes

- Fixed a bug where standalone engine can crash on tracing transactions
with too large contract deployment by [@birchmd]. ([#817])
- Fixed a bug and performance improvements with unusual exponents in the
`engine-modexp` crate by [@guidovranken]. ([#814])

---------

Co-authored-by: Guido Vranken <guidovranken@users.noreply.github.com>
Co-authored-by: Michael Birch <michael.birch@aurora.dev>
Co-authored-by: Joshua J. Bouw <joshua@aurora.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-standalone Area: the standalone engine EVM C-bug Category: Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants