engine-modexp bug fixes and performance improvements with unusual exponents
#814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksuss
added a commit
that referenced
this pull request
Aug 10, 2023
…xponents (#814) ## Description - Fixes a panic with empty exponent - Ensure correct result with zero exponent - Fix performance issues with exponents with large zero padding ## Performance / NEAR gas cost considerations The performance is increased for some cases (those with exponents with a large amount of leading zeroes) and remains the same for all other cases. ## Testing Fuzzing and tests added. ## How should this be reviewed ## Additional information --------- Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev>
Merged
aleksuss
added a commit
that referenced
this pull request
Aug 10, 2023
### Changes - Added a view transaction `factory_get_wnear_address` for returning address for the `wNEAR` ERC-20 contract by [@aleksuss]. ([#807]) ### Fixes - Fixed a bug where standalone engine can crash on tracing transactions with too large contract deployment by [@birchmd]. ([#817]) - Fixed a bug and performance improvements with unusual exponents in the `engine-modexp` crate by [@guidovranken]. ([#814]) --------- Co-authored-by: Guido Vranken <guidovranken@users.noreply.github.com> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: Joshua J. Bouw <joshua@aurora.dev>
mrLSD
approved these changes
Nov 18, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Performance / NEAR gas cost considerations
The performance is increased for some cases (those with exponents with a large amount of leading zeroes) and remains the same for all other cases.
Testing
Fuzzing and tests added.
How should this be reviewed
Additional information