Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize execution #5

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Optimize execution #5

merged 2 commits into from
Feb 28, 2022

Conversation

olonho
Copy link

@olonho olonho commented Feb 9, 2022

No description provided.

@olonho olonho marked this pull request as draft February 9, 2022 22:05
@olonho olonho force-pushed the better_interpreter branch 5 times, most recently from 09fb1de to 2659a2b Compare February 11, 2022 14:14
@olonho olonho marked this pull request as ready for review February 16, 2022 20:59
@olonho
Copy link
Author

olonho commented Feb 16, 2022

@birchmd could we start reviewing it, please.
Current gas cost is

NEAR_GAS_WASM 79964511306240
NEAR_GAS_TOTAL 325515158037144

@olonho olonho force-pushed the better_interpreter branch 3 times, most recently from a67ae57 to aa3c0e4 Compare February 17, 2022 09:50
@mfornet
Copy link

mfornet commented Feb 18, 2022

@birchmd could we start reviewing it, please. Current gas cost is

NEAR_GAS_WASM 79964511306240
NEAR_GAS_TOTAL 325515158037144

How did you get this numbers @olonho using aurora-engine benchmarks, or any other transaction?

@olonho
Copy link
Author

olonho commented Feb 18, 2022

Checked with

cargo test -p aurora-engine-tests --features mainnet-test test_uniswap_input_multihop -- --nocapture

in https://github.com/olonho/aurora-engine/tree/profiler2.

Same test on current master branch of Aurora engine (d2d30733b1560f0e30489bb47b615cf01c6df99c).

NEAR_GAS_WASM 88621257037104
NEAR_GAS_TOTAL 214213315595340

So we gain around 10%, and also possibilities for further optimizations, see https://github.com/olonho/sputnikvm/tree/small-opt.

Same test on current develop branch of Aurora engine (79afe11fa6c41fe8ab678cbe9919dac638423056), not different from master.

NEAR_GAS_WASM 88621257037104
NEAR_GAS_TOTAL 214213315595340

birchmd
birchmd reviewed Feb 18, 2022
View reviewed changes
Copy link
Member

@birchmd birchmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks really good over all. I just have a few questions.

core/src/lib.rs Outdated Show resolved Hide resolved
core/src/lib.rs Outdated Show resolved Hide resolved
src/executor/stack/executor.rs Show resolved Hide resolved
runtime/src/lib.rs Show resolved Hide resolved
birchmd
birchmd approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@birchmd birchmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @olonho !

joshuajbouw
joshuajbouw approved these changes Feb 28, 2022
View reviewed changes
Copy link

@joshuajbouw joshuajbouw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@birchmd birchmd merged commit 37448b6 into aurora-is-near:master Feb 28, 2022
@birchmd birchmd mentioned this pull request Feb 28, 2022
Merged
birchmd pushed a commit that referenced this pull request Aug 5, 2022
@olonho @birchmd
Optimize execution (#5)
7dfbeb5
birchmd pushed a commit that referenced this pull request Nov 3, 2022
@olonho @birchmd
Optimize execution (#5)
0d12ba3
birchmd pushed a commit that referenced this pull request Nov 25, 2022
@olonho @birchmd
Optimize execution (#5)
2f8df18
vimpunk pushed a commit that referenced this pull request May 18, 2023
@olonho @vimpunk
Optimize execution (#5)
4607136
vimpunk pushed a commit that referenced this pull request May 22, 2023
@olonho @vimpunk
Optimize execution (#5)
e959505
aleksuss added a commit to aleksuss/sputnikvm that referenced this pull request Jul 2, 2024
@aleksuss
test_32 bit aurora-is-near#5
877c393
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrLSD mrLSD mrLSD approved these changes

@joshuajbouw joshuajbouw joshuajbouw approved these changes

@birchmd birchmd birchmd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@olonho @mfornet @mrLSD @joshuajbouw @birchmd