Use prefixed seconds when possible for chrono-equivalent units #216
Labels
⬇️ affects: code (interfaces)
Affects the way end users will interact with the library
📁 kind: enhancement
New feature or request
💪 effort: small
Milestone
Comments
chiphogg
added
📁 kind: enhancement
chiphogg
added a commit
that referenced
this issue
Aug 2, 2024
Currently, we have a single generic correspondence for all chrono
durations. This is perfectly unit safe, but it means we have no labels
for any duration type, including common types like `std::chrono::hours`.
This means that `as_quantity(std::chrono::hours{3})` would print as
`"3 [UNLABELED UNIT]"` instead of `"3 h"`.
This PR defines a special correspondence for each commonly used chrono
duration type, which fixes the above behaviour.
As part of doing this, we found a missing dependency on `:quantity`, so
we added it in the BUILD file.
Fixes #216.
|
Update: fixed on main (https://godbolt.org/z/Kxe8vrh48). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See this link for current behaviour:
https://godbolt.org/z/vvsaz4Y3a
We could create a utility template that says, effectively, "if any of these prefixes produces a quantity-equivalent unit, then use that instead of just the unit-and-mag".
Of course, once #85 gets fixed, we won't see
[UNLABELED_UNIT]; we'll see something like[1 / 1000000000] s. But the prefixes would be a nicer user experience.The text was updated successfully, but these errors were encountered: