Fix bug that Content-Encoding won't be written to final response header for gzip and deflate #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 21, 2023 17:09
…er for gzip and deflate
|
Sorry, this MR includes the module name changes. You may need to cherry pick the second commit only for the fix. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For gzip and deflate, gin.ResponseWriter.Write() will be called before ResponseWriter.Header().Set(). In this case, the ResponseWriter.Write() will call ResponseWriter.WriteHeaderNow(), and write the header to final response without encoding related headers. In this fix, ResponseWriter.Header().Set() was moved to before any call to gin.ResponseWriter.Write().