chore(deps): update all deps and fix database schema #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ya-woodcutter
force-pushed
the
update-deps
branch
from
47c803d
to
af31115
Compare
evilj0e
requested changes
Jun 25, 2019
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "unity-cache", | |||
| "version": "2.1.0", | |||
| "description": "Cache abstraction around localforage.", | |||
| "version": "2.2.0", | |||
There was a problem hiding this comment.
You updated node to major version. I think it should been updated to major.
There was a problem hiding this comment.
Node is used only in testing environment. I'm not sure about the major version.
| "version": "2.1.0", | ||
| "description": "Cache abstraction around localforage.", | ||
| "version": "2.2.0", | ||
| "description": "Cache abstraction around Dexie.", |
| config: {}, | ||
| db: null | ||
| db: null, | ||
| config: {} |
There was a problem hiding this comment.
It's like a tree 🌲
| stores = stores.reduce((result, storeName) => { | ||
| if (!RE_BIN.test(storeName)) { | ||
| throw new UnityCacheError(`Store names can only be alphanumeric, '${storeName}' given`); | ||
| } | ||
|
|
||
| result[storeName] = '&'; | ||
| result[storeName] = '&key, value, expire'; |
There was a problem hiding this comment.
To remove EXPIRE_BIN
| const { db } = cacheInstance; | ||
| const expire = Date.now() + Number(ttl); |
There was a problem hiding this comment.
Number('fdfff') // NaN
I think it would be better to check its type before
There was a problem hiding this comment.
I think it would be better to rewrite it to typescript. The check doesn't help at all.
|
|
||
| const indexedDB = require('fake-indexeddb'); | ||
| const FDBKeyRange = require('fake-indexeddb/lib/FDBKeyRange'); | ||
|
|
||
| window.Promise = global.Promise; |
There was a problem hiding this comment.
Cause Dexie uses Promise from window.
evilj0e
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.