[MIRROR] TGUI maintenance chores and juke upgrades #4717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AustationBot
added
Code Improvement
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
remirror |
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> Co-authored-by: mokulus <36231852+mokulus@users.noreply.github.com> Co-authored-by: SplinterGP <isseisanloverias@gmail.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
AustationBot
force-pushed
the
upstream-merge-6247
branch
from
e982247
to
ccdea1e
Compare
TheFakeElon
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: BeeStation/BeeStation-Hornet#6247
About The Pull Request
Ports several juke/tgs changes to resolve some of our technical debt and to get the TGUI dev server working again.
Ported the following:
Why It's Good For The Game
General TGUI improvements and QoL changes for development.
Interacting with TGUI has changed drastically. There is no longer a
bin/tguiscript to interact with. Instead, developers will need to use either the windows scripts found in thebin/root directory, via Juke, or via yarn. Excerpt from the updatedtgui/README.mdbelow.TGUI usage
Via provided cmd scripts (Windows):
bin/tgui-build- Build tgui in production mode and run a full suite of code checks.bin/tgui-dev- Launch a development server.bin/tgui-dev --reload- Reload byond cache once.bin/tgui-dev --debug- Run server with debug logging enabled.bin/tgui-dev --no-hot- Disable hot module replacement (helps when doing development on IE8).bin/tgui-sonar- Analyze code with SonarQube.bin/tgui-bench- Run benchmarks.Via Juke Build (cross-platform):
tools/build/build tgui- Build tgui in production mode.tools/build/build tgui-dev- Build tgui in production mode.tools/build/build tgui-dev --reload- Reload byond cache once.tools/build/build tgui-dev --debug- Run server with debug logging enabled.tools/build/build tgui-dev --no-hot- Disable hot module replacement (helps when doing development on IE8).tools/build/build tgui-lint- Show (and auto-fix) problems with the code.tools/build/build tgui-sonar- Analyze code with SonarQube.tools/build/build tgui-test- Run unit and integration tests.tools/build/build tgui-analyze- Run a bundle analyzer.tools/build/build tgui-bench- Run benchmarks.tools/build/build tgui-clean- Clean up tgui folder.Via Yarn (cross-platform):
Run
yarn installonce to install tgui dependencies.yarn tgui:build- Build tgui in production mode.yarn tgui:build [options]- Build tgui with custom webpack options.yarn tgui:dev- Launch a development server.yarn tgui:dev --reload- Reload byond cache once.yarn tgui:dev --debug- Run server with debug logging enabled.yarn tgui:dev --no-hot- Disable hot module replacement (helps when doing development on IE8).yarn tgui:lint- Show (and auto-fix) problems with the code.yarn tgui:sonar- Analyze code with SonarQube.yarn tgui:tsc- Check code with TypeScript compiler.yarn tgui:test- Run unit and integration tests.yarn tgui:analyze- Run a bundle analyzer.yarn tgui:bench- Run benchmarks.Testing Photographs and Procedure
BUILD.battools/build/buildbin/*.cmdscriptsScreenshots&Videos
Changelog
🆑stylemistake,SplinterGP,mokulus
code: Treat DreamMaker warnings as errors in CI
refactor: Performance of core tgui components was improved (Button, Icon, Flex, Stack). UI should feel a tiny bit faster.
/:cl: