tgui maintenance chores #60859
Merged
tgui maintenance chores #60859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
Tools
stylemistake
force-pushed
the
tgui-upgrade-post-juke
branch
from
ddeb470
to
11abd20
Compare
Cyberboss
approved these changes
Aug 16, 2021
SplinterGP
added a commit
to SplinterGP/TerraGov-Marine-Corps
that referenced
this pull request
Oct 10, 2021
ZeWaka
added a commit
to goonstation/goonstation
that referenced
this pull request
Oct 12, 2021
BraveMole
pushed a commit
to tgstation/TerraGov-Marine-Corps
that referenced
this pull request
Oct 15, 2021
* i should have split this into different commits but tgstation/tgstation#60695 tgstation/tgstation#60736 tgstation/tgstation#60775 tgstation/tgstation#60859 * Juke build 0.8.1/0.9.0/0.8.1 revert tgstation/tgstation#60404 tgstation/tgstation#60897 tgstation/tgstation#61025 tgstation/tgstation#61110 tgstation/tgstation#61005 * allow cancel tgui alert tgstation/tgstation#61072 * TGUI bench tgstation/tgstation#61081 * upgrade stuff from tgstation/tgstation#61313 * component stuff from tgstation/tgstation#61381 * improvements from: tgstation/tgstation#61925 tgstation/tgstation#61496 tgstation/tgstation#61381 * aaaaaaaaaaaa * linter errors * no strictnullcheckyet * Tooltip: tgstation/tgstation#61783 and types.ts i forgot * oops * i hate git why was this still here * stuff i forgot * aaa * strictnullchecks fixes * button stuff i jumped * TGUI tasks
LemonInTheDark
pushed a commit
to LemonInTheDark/tgstation
that referenced
this pull request
Dec 12, 2021
* tgui maintenance chores (tgstation#60859) ## About The Pull Request **Upgrades:** - Yarn 3.0 - TypeScript 4.3 - Sass 1.37 - Required some refactoring of `/` into `math.div()` in CSS **Dependency removals:** - Removed ESM package, see: standard-things/esm#902 I initially thought it was impossible to stop relying on this package, but fortunately, ES module support in Node 12+ now comes standard and I only had to convert the very few external module imports to `require()` (because Yarn PnP). I also moved `logging.js` directly into `tgui-dev-server` package, because that's where it is used. One less internal dependency. **Sidegrades:** - Removed creation of a common tgui chunk, because in practice it creates unnecessary complexity (devs sometimes get a white screen due to this chunk being invalid) and doesn't really save that much data on CDN, and **definitely** doesn't make tgui load faster. I think that is all. I tested it a bit and everything seemingly works. * tgui maintenance chores Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
ZeWaka
added a commit
to goonstation/goonstation
that referenced
this pull request
Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Upgrades:
/intomath.div()in CSSDependency removals:
I initially thought it was impossible to stop relying on this package, but fortunately, ES module support in Node 12+ now comes standard and I only had to convert the very few external module imports to
require()(because Yarn PnP).I also moved
logging.jsdirectly intotgui-dev-serverpackage, because that's where it is used. One less internal dependency.Sidegrades:
I think that is all. I tested it a bit and everything seemingly works.