Logical precedence problem fixed #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR :) Can you elaborate on this fix, specifically in what cases the existing code would fail? Thanks! |
|
Chenkie - have a look at the code. Line 47 of user-routes has the following line: if(!user.password === req.body.password) { This will cause user.password to be evaluated for a truthy/falsy value and then compared with req.body.password. This pull request checks for equality between the two values and then negates the result. Did you intend the result to be false unless the password is an empty string? |
|
Sorry. Didn't comment because I got no mail notification :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.