Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCAG Merge, localization, and custom fields fixes #87

Merged
merged 54 commits into from
May 30, 2018

Conversation

mostekcm
Copy link
Contributor

@mostekcm mostekcm commented Feb 12, 2018

This is another fairly significant update. Phase 1 is to add validation support for the fields.

This does both client side and server side validation. The server side validation is really just to prevent users from circumventing the client side validation. It will also protect against role escalation by protecting against a user creating another user with a higher level role that they would have access to.

In order to make this considerably easier, I did a significant refactor on the dialogs. They are now using common code. This could potentially use another iteration as there is still a ton of template-able code in the dialogs.

@Verlic
Copy link

Verlic commented Feb 12, 2018

MD5: ff035bff2dcf972ee7dfd023455997ef

NSP - Security Report

This is an automated security audit of this project. Please do not modify its contents

Vulnerabilities found: 18
Affected Modules: hoek, hoek, hoek, hoek, superagent, superagent, superagent, mime, mime, mime, mime, mime, superagent, superagent, debug, fresh, safe-eval, superagent
Summary:

  • Prototype pollution attack
  • Prototype pollution attack
  • Prototype pollution attack
  • Prototype pollution attack
  • Large gzip Denial of Service
  • Large gzip Denial of Service
  • Large gzip Denial of Service
  • Regular Expression Denial of Service
  • Regular Expression Denial of Service
  • Regular Expression Denial of Service
  • Regular Expression Denial of Service
  • Regular Expression Denial of Service
  • Large gzip Denial of Service
  • Large gzip Denial of Service
  • Regular Expression Denial of Service
  • Regular Expression Denial of Service
  • Sandbox Breakout
  • Large gzip Denial of Service

Detailed report

Prototype pollution attack

Affected Module: hoek
Installed version: 2.16.3
Patched versions: > 4.2.0 < 5.0.0 || >= 5.0.3
Advisory: https://nodesecurity.io/advisories/566
Path: auth0-delegated-admin@3.0.0 > auth0-extension-express-tools@1.1.0 > webtask-tools@3.2.0 > boom@2.10.1 > hoek@2.16.3


Prototype pollution attack

Affected Module: hoek
Installed version: 2.16.3
Patched versions: > 4.2.0 < 5.0.0 || >= 5.0.3
Advisory: https://nodesecurity.io/advisories/566
Path: auth0-delegated-admin@3.0.0 > auth0-extension-tools@1.2.1 > jsonwebtoken@7.4.3 > joi@6.10.1 > hoek@2.16.3


Prototype pollution attack

Affected Module: hoek
Installed version: 2.16.3
Patched versions: > 4.2.0 < 5.0.0 || >= 5.0.3
Advisory: https://nodesecurity.io/advisories/566
Path: auth0-delegated-admin@3.0.0 > jsonwebtoken@7.4.3 > joi@6.10.1 > hoek@2.16.3


Prototype pollution attack

Affected Module: hoek
Installed version: 2.16.3
Patched versions: > 4.2.0 < 5.0.0 || >= 5.0.3
Advisory: https://nodesecurity.io/advisories/566
Path: auth0-delegated-admin@3.0.0 > webtask-tools@3.2.0 > boom@2.10.1 > hoek@2.16.3


Large gzip Denial of Service

Affected Module: superagent
Installed version: 1.8.5
Patched versions: >=3.7.0
Advisory: https://nodesecurity.io/advisories/479
Path: auth0-delegated-admin@3.0.0 > auth0-extension-express-tools@1.1.0 > webtask-tools@3.2.0 > superagent@1.8.5


Large gzip Denial of Service

Affected Module: superagent
Installed version: 1.8.5
Patched versions: >=3.7.0
Advisory: https://nodesecurity.io/advisories/479
Path: auth0-delegated-admin@3.0.0 > auth0-extension-tools@1.2.1 > webtask-tools@2.2.0 > superagent@1.8.5


Large gzip Denial of Service

Affected Module: superagent
Installed version: 1.8.5
Patched versions: >=3.7.0
Advisory: https://nodesecurity.io/advisories/479
Path: auth0-delegated-admin@3.0.0 > webtask-tools@3.2.0 > superagent@1.8.5


Regular Expression Denial of Service

Affected Module: mime
Installed version: 1.3.4
Patched versions: >= 1.4.1 < 2.0.0 || >= 2.0.3
Advisory: https://nodesecurity.io/advisories/535
Path: auth0-delegated-admin@3.0.0 > auth0-extension-express-tools@1.1.0 > webtask-tools@3.2.0 > superagent@1.8.5 > mime@1.3.4


Regular Expression Denial of Service

Affected Module: mime
Installed version: 1.3.4
Patched versions: >= 1.4.1 < 2.0.0 || >= 2.0.3
Advisory: https://nodesecurity.io/advisories/535
Path: auth0-delegated-admin@3.0.0 > auth0-extension-tools@1.2.1 > webtask-tools@2.2.0 > superagent@1.8.5 > mime@1.3.4


Regular Expression Denial of Service

Affected Module: mime
Installed version: 1.3.4
Patched versions: >= 1.4.1 < 2.0.0 || >= 2.0.3
Advisory: https://nodesecurity.io/advisories/535
Path: auth0-delegated-admin@3.0.0 > express@4.14.0 > send@0.14.1 > mime@1.3.4


Regular Expression Denial of Service

Affected Module: mime
Installed version: 1.3.4
Patched versions: >= 1.4.1 < 2.0.0 || >= 2.0.3
Advisory: https://nodesecurity.io/advisories/535
Path: auth0-delegated-admin@3.0.0 > superagent@1.2.0 > mime@1.3.4


Regular Expression Denial of Service

Affected Module: mime
Installed version: 1.3.4
Patched versions: >= 1.4.1 < 2.0.0 || >= 2.0.3
Advisory: https://nodesecurity.io/advisories/535
Path: auth0-delegated-admin@3.0.0 > webtask-tools@3.2.0 > superagent@1.8.5 > mime@1.3.4


Large gzip Denial of Service

Affected Module: superagent
Installed version: 2.3.0
Patched versions: >=3.7.0
Advisory: https://nodesecurity.io/advisories/479
Path: auth0-delegated-admin@3.0.0 > auth0-extension-express-tools@1.1.0 > auth0-extension-tools@1.3.1 > superagent@2.3.0


Large gzip Denial of Service

Affected Module: superagent
Installed version: 2.3.0
Patched versions: >=3.7.0
Advisory: https://nodesecurity.io/advisories/479
Path: auth0-delegated-admin@3.0.0 > auth0-extension-tools@1.2.1 > superagent@2.3.0


Regular Expression Denial of Service

Affected Module: debug
Installed version: 2.2.0
Patched versions: >= 2.6.9 < 3.0.0 || >= 3.1.0
Advisory: https://nodesecurity.io/advisories/534
Path: auth0-delegated-admin@3.0.0 > express@4.14.0 > debug@2.2.0


Regular Expression Denial of Service

Affected Module: fresh
Installed version: 0.3.0
Patched versions: >= 0.5.2
Advisory: https://nodesecurity.io/advisories/526
Path: auth0-delegated-admin@3.0.0 > express@4.14.0 > fresh@0.3.0


Sandbox Breakout

Affected Module: safe-eval
Installed version: 0.3.0
Patched versions: <0.0.0
Advisory: https://nodesecurity.io/advisories/337
Path: auth0-delegated-admin@3.0.0 > safe-eval@0.3.0


Large gzip Denial of Service

Affected Module: superagent
Installed version: 1.2.0
Patched versions: >=3.7.0
Advisory: https://nodesecurity.io/advisories/479
Path: auth0-delegated-admin@3.0.0 > superagent@1.2.0


Oleksandr Zarubin and others added 25 commits February 16, 2018 17:09
…t aren't defined as create fields, fix connection label bug
…sername back instead of description or log description if it is in the log
* localizable placeholders for custom fields

* localizable confirm dialog buttons

* errorTranslator function
* remove guardian fix; dashboard admin access_token fix

* remove multiple mfa
fix another en.json example
* localizable confirm dialog buttons

* errorTranslator function

* reload settings when settings hook is saved

* username field validation fix; email/username change fix
* localizable confirm dialog buttons

* localizable confirm dialog buttons

* errorTranslator function

* errorTranslator function

* localizable labels

* user info labels

* logs localization fixes; added missed logTypes; complete dictionary

* new setting props

* unit-tests

* restore nyc for unit-tests

* auditor (read-only) role
* localizable confirm dialog buttons

* localizable confirm dialog buttons

* localizable confirm dialog buttons

* errorTranslator function

* errorTranslator function

* errorTranslator function

* unit-tests

* restore nyc for unit-tests

* hidden label for searchBar

* dynamic page title

* image and icon titles

* Meaningful sequence: focus results after search; tests

* alternative custom css

* docs, examples and cleanup

* tests

* log description for user logs + tests

* locale
zxan1285 and others added 24 commits March 6, 2018 11:29
* localizable confirm dialog buttons

* errorTranslator function

* reload settings when settings hook is saved

* username field validation fix; email/username change fix

* localizable confirm dialog buttons

* localizable confirm dialog buttons

* errorTranslator function

* errorTranslator function

* localizable labels

* user info labels

* logs localization fixes; added missed logTypes; complete dictionary

* new setting props

* unit-tests

* restore nyc for unit-tests

* auditor (read-only) role

* hidden label for searchBar

* dynamic page title

* image and icon titles

* Meaningful sequence: focus results after search; tests
* mandatory locale

* edit.display for change forms

* get style settings instead of checking localstorage directly
extension-ui version + minor localization fixes
* locale url fixes, usersTable and display func fixes, dictionary request headers fix

* undefined css fix

The one thing I'm wondering is whether the redirectUri change will be a problem with the callbackUrls...  I'm not sure it should be necessary.  We should be able to find a way around that...
…ng lotType description, this should ONLY be used if you really don't want any non-localized values
* display for picture

* login redirect fix

* mfa tests fix

* listOrder fix
… have a field that gets set during password change
…or onlyTheseFields to only those fields to avoid someone adding an extra field to tag along
* requesting connections by stategy

* limit connections to 100

* use search_engine v3 by default; added SEARCH_ENGINE option

* searchEngine option added to the filter hook

* conn and clients multipart request

* fix "Running in Development" doc

* cleanup

* cleanup

* tools update

* filterBy prop for pagination
Default searchEngine option
@mostekcm mostekcm changed the title [DO NOT MERGE] WCAG Preview WCAG Merge, localization, and custom fields fixes May 30, 2018
@mostekcm mostekcm merged commit e2751f4 into auth0-extensions:master May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants