Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE when browser re-attempts a finished authentication #143

Merged
merged 2 commits into from
Feb 1, 2018
Merged

Fix NPE when browser re-attempts a finished authentication #143

merged 2 commits into from
Feb 1, 2018

Conversation

lbalmaceda
Copy link
Contributor

@lbalmaceda lbalmaceda commented Feb 1, 2018 •
edited

This PR also removes the unwanted NO_HISTORY flag to prevent auto browser refreshing when minimized.
Fixes #137

cocojoe
cocojoe approved these changes Feb 1, 2018
View reviewed changes
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbalmaceda lbalmaceda merged commit 90b9a19 into master Feb 1, 2018
@lbalmaceda lbalmaceda added this to the v1-Next milestone Feb 1, 2018
@lbalmaceda lbalmaceda deleted the webauth-browser-fix branch February 1, 2018 21:16
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.12.1 Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocojoe cocojoe cocojoe approved these changes

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
1.12.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lbalmaceda @cocojoe