Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make connection_scope separate values with comma #236

Merged
merged 1 commit into from
May 28, 2019
Merged

Make connection_scope separate values with comma #236

merged 1 commit into from
May 28, 2019

Conversation

lbalmaceda
Copy link
Contributor

Changes

The server expects the connection_scope value to be a comma separated string, rather than a whitespace separated string.

Testing

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@lbalmaceda lbalmaceda requested a review from a team May 28, 2019 14:17
@lbalmaceda lbalmaceda added the small Small review label May 28, 2019
@lbalmaceda lbalmaceda added this to the v1-Next milestone May 28, 2019
@lbalmaceda lbalmaceda merged commit 362915e into master May 28, 2019
@lbalmaceda lbalmaceda deleted the fix-conn-scope branch May 28, 2019 20:07
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.16.0 Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcanhelp joshcanhelp joshcanhelp approved these changes

Assignees
No one assigned
Labels
CH: Fixed small Small review
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lbalmaceda @joshcanhelp