Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Web authentication cancel scenario #240

Merged
merged 3 commits into from
Jun 14, 2019
Merged

Conversation

lbalmaceda
Copy link
Contributor

Changes

Now when pressing the back key (or closing the browser/webview activity) the callback will receive a call to onFailure with an AuthenticationException.
On this exception one could call isAuthenticationCanceled() to determine if the error was caused because of the user canceling an authentication process.

The change is compatible with browser authentication and also with webview authentication (deprecated).

References

Closes #127

Testing

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@lbalmaceda lbalmaceda added CH: Added medium Medium review labels Jun 11, 2019
@lbalmaceda lbalmaceda added this to the v1-Next milestone Jun 11, 2019
@lbalmaceda lbalmaceda requested a review from a team June 11, 2019 21:37
@lbalmaceda lbalmaceda changed the title Webauth cancel Support Web authentication cancel scenario Jun 11, 2019
@lbalmaceda lbalmaceda merged commit d492d28 into master Jun 14, 2019
@lbalmaceda lbalmaceda deleted the webauth-cancel branch June 14, 2019 19:12
@h-mubarak
Copy link

Is this branch merged with the current available auth0 version(1.15.2)? I am using this version but not able to see the changes.

@TWiStErRob
Copy link

@h-mubarak on GitHub PRs there's a commit when the PR is merged. Click on the commit hash above your comment (d492d28) and you'll see the details. If there's a version tag after the branch icon, it's included in that release. See for example this older PR merge commit: e82f4de

@h-mubarak
Copy link

Thanks for detail info @TWiStErRob, Shall i know when this merge will get versioned so that i can use it.

@sklr13
Copy link

sklr13 commented Jun 18, 2019

@TWiStErRob I am also interested in this feature because without it I will have a huge and ugly workaround. Can you please provide the information when it will be approximately released?

@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.16.0 Jun 18, 2019
@lbalmaceda
Copy link
Contributor Author

Released under 1.16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Added medium Medium review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent behaviour compared to iOS Auth0 when pressing back button
5 participants