Deprecate Legacy Authentication APIs #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
suggested changes
Dec 17, 2020
| @@ -153,8 +171,11 @@ public ParameterBuilder setAudience(@NonNull String audience) { | |||
| * | |||
| * @param device a device name | |||
| * @return itself | |||
| * | |||
| * @deprecated TODO | |||
There was a problem hiding this comment.
Reason is RO being legacy API being removed in the next major
That's RO https://auth0.com/docs/api/authentication#database-ad-ldap-active-
There was a problem hiding this comment.
Pushed a new commit to add this.
| @@ -63,11 +70,22 @@ | |||
| public static final String SCOPE_OPENID = "openid"; | |||
| public static final String SCOPE_OFFLINE_ACCESS = "openid offline_access"; | |||
|
|
|||
| /** | |||
| * @deprecated The {@code id_token} parameter is only used when making requests to the legacy | |||
There was a problem hiding this comment.
I'd link to https://auth0.com/docs/api/authentication#database-ad-ldap-active- as you did in others.
Also, DEVICE constant is still here. Should go away with ID token, same reason
There was a problem hiding this comment.
Pushed a new commit to add the link and also deprecate the DEVICE constant
lbalmaceda
suggested changes
Dec 17, 2020
auth0/src/main/java/com/auth0/android/request/internal/BaseAuthenticationRequest.java
Outdated
Show resolved
Hide resolved
…henticationRequest.java Co-authored-by: Luciano Balmaceda <balmacedaluciano@gmail.com>
lbalmaceda
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Deprecates methods and classes associated with the legacy Auth0 Authentication APIs.
Classes deprecated:
DelegationDelegationRequestMethods deprecated:
AuthenticationAPIClient#loginWithOAuthAccessToken(@NonNull String token, @NonNull String connection)AuthenticationAPIClient#delegationWithIdToken(@NonNull String idToken)AuthenticationAPIClient#delegationWithRefreshToken(@NonNull String refreshToken)AuthenticationAPIClient#delegationWithIdToken(@NonNull String idToken, @NonNull String apiType)AuthenticationAPIClient#delegation()ParameterBuilder#setAccessToken(@NonNull String accessToken)SignupRequest#setAccessToken(@NonNull String accessToken)AuthenticationRequest#setAccessToken(@NonNull String accessToken)BaseAuthenticationRequest#setAccessToken(@NonNull String accessToken)Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors