Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove timeouts and logging setters from Auth0 class #441

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

lbalmaceda
Copy link
Contributor

Changes

This class is shared across the 3 clients (both APIs & WebAuth). It is a good place to share setup options, common across the entire library. Previously it supported being set read/connect timeouts and enabling the HTTP logger. Since that logic is too coupled with the DefaultClient implementation, this PR removes these properties from the Auth0 class in favor of keeping them in the client implementation instead.

The summary of removed methods:

  • setter/getter for isLoggingEnabled
  • setter/getter for connectTimeoutInSeconds
  • setter/getter for readTimeoutInSeconds

@lbalmaceda lbalmaceda added this to the v2-Next milestone Jan 19, 2021
@lbalmaceda lbalmaceda requested a review from a team as a code owner January 19, 2021 17:06
@lbalmaceda lbalmaceda merged commit 1365c65 into v2-dev Jan 19, 2021
@lbalmaceda lbalmaceda deleted the rm-auth0-setters branch January 19, 2021 17:16
@lbalmaceda lbalmaceda modified the milestones: v2-Next, 2.0.0-beta.0 Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants