Remove timeouts and logging setters from Auth0 class #441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This class is shared across the 3 clients (both APIs & WebAuth). It is a good place to share setup options, common across the entire library. Previously it supported being set read/connect timeouts and enabling the HTTP logger. Since that logic is too coupled with the
DefaultClient
implementation, this PR removes these properties from the Auth0 class in favor of keeping them in the client implementation instead.The summary of removed methods:
isLoggingEnabled
connectTimeoutInSeconds
readTimeoutInSeconds