Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3144] Add user property to Credentials #569

Merged
merged 4 commits into from
Jun 20, 2022
Merged

Conversation

adamjmcgrath
Copy link
Contributor

Changes

Added the user property to Credentials
Exposed a couple of methods on the Jwt helper to support this

Usage

authentication
    .login("info@auth0.com", "a secret password", "my-database-connection")
    .start(object: Callback<Credentials, AuthenticationException> {
        override fun onSuccess(credentials: Credentials) {
            println(credentials.user.name)
        }
    })

I didn't make it a Delegated Property because I couldn't get Gson to deserialize it (see https://stackoverflow.com/a/57604781)

Testing

Login to the sample app, note the new "Hello YOUR_NAME" greeting.

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@adamjmcgrath adamjmcgrath requested a review from a team as a code owner June 14, 2022 14:43
Copy link
Contributor

@poovamraj poovamraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poovamraj poovamraj merged commit 56fc260 into vNext Jun 20, 2022
@poovamraj poovamraj added this to the v2-Next milestone Jun 22, 2022
@frederikprijck frederikprijck mentioned this pull request Jul 5, 2022
@poovamraj poovamraj deleted the credentials-user branch July 18, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants