[SDK-3352] Expire credentials based on access token alone #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjmcgrath
commented
Jun 17, 2022
| @@ -1080,13 +1080,6 @@ public class SecureCredentialsManagerTest { | |||
| MatcherAssert.assertThat(manager.hasValidCredentials(), Is.`is`(true)) | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
There's no logic in hasValidCredentials that checks if the AT and IdT are missing
poovamraj
approved these changes
Jun 20, 2022
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
expclaim on the ID token is for validating the token claims when the ID token is processed, not for setting the duration of the session.References
https://openid.net/specs/openid-connect-core-1_0.html#IDToken:~:text=exp-,REQUIRED.%20Expiration%20time%20on%20or%20after%20which%20the%20ID%20Token%20MUST,iat,-REQUIRED.%20Time%20at
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. Since this library has unit testing, tests should be added for new functionality and existing tests should complete without errors.
This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors