Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3353] Validate claims for ID Token received in Authentication API Client #575

Merged
merged 2 commits into from
Jun 17, 2022
Merged

[3353] Validate claims for ID Token received in Authentication API Client #575

merged 2 commits into from
Jun 17, 2022

Conversation

poovamraj
Copy link
Contributor

Changes

  • We have added a new method validateClaims() for Authentication Request and Signup Request
  • withIdTokenVerificationIssuer and withIdTokenVerificationLeeway are added to customize the claim validation
  • README and documentation are updated
  • IdTokenVerifier now has an option where signature verification is optional
  • IdTokenVerificationOptions is converted to Kotlin

References

We have internal discovery regarding this linked in the ticket mentioned in title

Testing

We have added unit tests and tested it manually as well

@poovamraj poovamraj added this to the v2-Next milestone Jun 16, 2022
@poovamraj poovamraj requested a review from a team as a code owner June 16, 2022 22:32
Widcket
Widcket reviewed Jun 16, 2022
View reviewed changes
README.md Show resolved Hide resolved
@poovamraj poovamraj merged commit e2c6915 into vNext Jun 17, 2022
@frederikprijck frederikprijck mentioned this pull request Jul 5, 2022
Merged
@poovamraj poovamraj deleted the validate-claims-for-api-client-id-token branch July 18, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket left review comments

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
CH: Added review:large Large review
Projects
None yet
Milestone
v2-Next
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@poovamraj @adamjmcgrath @Widcket