Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3350] Empty credentials before continuing should throw CredentialsManagerException #576

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

poovamraj
Copy link
Contributor

Changes

Trying to fetch the credentials JSON after it has been cleared was not throwing exception inside continueGetCredentials. We have added a CredentialsManagerException for this case.

This was missed out previously since continueGetCredentials would be called after the check for validCredentials in getCredentials method but this misses out 2 scenarios

  • Credential being cleared before reaching continuingGetCredentials by another thread
  • Credential being cleared before checkAuthenticationResult

References

GH Issue - #555

Testing

We have added a test case to our Unit test suite. We also did an integration test by the case mentioned in the GH issue

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

@poovamraj poovamraj merged commit a908568 into vNext Jun 20, 2022
@poovamraj poovamraj added this to the v2-Next milestone Jun 22, 2022
@frederikprijck frederikprijck mentioned this pull request Jul 5, 2022
@poovamraj poovamraj deleted the empty-refresh-token-exception branch July 18, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants