[SDK-3350] Empty credentials before continuing should throw CredentialsManagerException #576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Trying to fetch the credentials JSON after it has been cleared was not throwing exception inside
continueGetCredentials
. We have added a CredentialsManagerException for this case.This was missed out previously since
continueGetCredentials
would be called after the check forvalidCredentials
ingetCredentials
method but this misses out 2 scenarioscontinuingGetCredentials
by another threadcheckAuthenticationResult
References
GH Issue - #555
Testing
We have added a test case to our Unit test suite. We also did an integration test by the case mentioned in the GH issue
This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not