Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3329] Improved ID token exception API #577

Merged
merged 2 commits into from
Jun 22, 2022
Merged

[SDK-3329] Improved ID token exception API #577

merged 2 commits into from
Jun 22, 2022

Conversation

poovamraj
Copy link
Contributor

Changes

We have improved the exception thrown for token validation without affecting the backward compatibility.

  • We throw a straightforward Exception of the error which is the sub class of the previous TokenValidationException
  • The string used to compare the exception previously is maintained by overriding toString()
  • We have a new flag in AuthenticationException for isIdTokenValidationError

References

  • We have a few references in the internal ticket mentioned in the PR title.

Testing

All the unit test cases are updated. The integration test is done manually.

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

@poovamraj poovamraj requested a review from a team as a code owner June 21, 2022 16:35
@poovamraj poovamraj added this to the v2-Next milestone Jun 22, 2022
@poovamraj poovamraj merged commit dd1b9fd into vNext Jun 22, 2022
@frederikprijck frederikprijck mentioned this pull request Jul 5, 2022
Merged
@poovamraj poovamraj deleted the token-validation-exception-improvement branch July 18, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
v2-Next
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@poovamraj @adamjmcgrath