[SDK-3452] Network Exception Issue Fix #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjmcgrath
previously approved these changes
Jun 23, 2022
adamjmcgrath
approved these changes
Jun 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
isNetworkErrorinAuthenticationExceptionhasn't been working since we have not properly thrownNetworkErrorExceptionfrom any of theErrorAdapters (Both inAuthenticationAPIClientandUserAPIClient)To fix this issue without breaking the current behaviour, instead of starting to throw NetworkErrorException we have handled the boolean flag to accept
SocketTimeoutExceptionandUnknownHostExceptionWe have not used the broader
IOExceptionsince it can be found in JSON parsing or other functionalities as wellReferences
Closes #558
Testing
This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not