Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3348] Implement trusted web activity support #631

Merged
merged 15 commits into from Feb 7, 2023
Merged

[SDK-3348] Implement trusted web activity support #631

merged 15 commits into from Feb 7, 2023

Conversation

poovamraj
Copy link
Contributor

@poovamraj poovamraj commented Jan 31, 2023 •
edited

Changes

Warning
This is an experimental feature that can be changed in the future

Trusted Web Activity is a feature provided by some browsers to provide a native feel to the custom tabs.
We have implemented this feature to web authentication to provide a more native login experience using web login

WebAuthProvider.login(account)
    .withTrustedWebActivity()
    .await(this)

References

https://developer.chrome.com/docs/android/trusted-web-activity/

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. Since this library has unit testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

@poovamraj poovamraj requested a review from a team as a code owner January 31, 2023 12:25
@poovamraj poovamraj changed the title [SDK-3348] Implement trusted web activities [SDK-3348] Implement trusted web activity support Jan 31, 2023
@poovamraj poovamraj marked this pull request as draft January 31, 2023 12:25
@poovamraj poovamraj marked this pull request as ready for review February 6, 2023 14:47
jimmyjames
jimmyjames requested changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions to the examples, and a question about a change to a public APIs signature.

EXAMPLES.md Outdated Show resolved Hide resolved
EXAMPLES.md Outdated Show resolved Hide resolved
auth0/src/main/java/com/auth0/android/annotation/ExperimentalAuth0Api.java Show resolved Hide resolved
auth0/src/main/java/com/auth0/android/provider/CustomTabsController.java Outdated Show resolved Hide resolved
poovamraj and others added 4 commits February 6, 2023 23:42
@poovamraj poovamraj merged commit 2764fc9 into main Feb 7, 2023
@poovamraj poovamraj deleted the implement-trusted-web-activities branch February 7, 2023 05:52
@poovamraj poovamraj mentioned this pull request Feb 9, 2023
Closed
@poovamraj poovamraj added this to the 2.9.0 milestone Mar 16, 2023
This was referenced Mar 16, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyjames jimmyjames jimmyjames approved these changes

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@poovamraj @jimmyjames