Update Okio to resolve CVE-2023-3635 #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansims
previously approved these changes
Sep 21, 2023
jimmyjames
force-pushed
the
update-okhttp
branch
from
f6cb5ff
to
b1bd21b
Compare
|
@evansims any idea why the snyk check is failing? It's unable to find a JAVA_HOME when executing gradle, and I notice the snyk runner is set to use the php one, is that correct? Also I don't see that workflow having run as part of the initial PR to add GH actions. Looks like the same issue is also blocking #690 |
poovamraj
approved these changes
Oct 3, 2023
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excludes transient dependency okio from OkHttp and include 3.5.0 which resolves CVE-2023-3635. Once OkHttp 4.12.0 is released we can remove the manual okio dependency and exclude rule.
This change also updates the Kotlin version to 1.8, as Okio requires it beyond 3.2.0, as well as the Gradle version to 6.9.3