Clean up Swift warnings in Xcode 10.2 #264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocojoe
changed the title
|
will this be merged into new version ? |
|
I just need to find the time to double check it. In general whenever we have a new version of Xcode we go through this process. It's nice to do but not critical. |
omerjanjua
approved these changes
Apr 17, 2019
|
We have these warnings sticking out like a sore thumb in our project. Can this PR get merged, please? |
|
I'm working on a PR to address the bigger issue of Swift 5 / Xcode 10.2 and the retirement of Swift 3. It will include the minor issue of cleaning up warnings. |
|
See #272 |
|
Resolved in #272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
remove
publicaccess modifier wherepublicis redundant.References
#263