Added Swift 5 / Xcode 10.2 Support #272
Conversation
Update macOS to 10.11 Update Test dependencies Swift 5 Fix Warnings Removed ObjC Testing Update Readme Update Fastlane PodSpec Minimum versions align with Xcode
Force try to fix nil not <nil> in Swift 4.2 Signed-off-by: Martin Walsh <martin.walsh@gmail.com>
| environment: | ||
| LC_ALL: en_US.UTF-8 | ||
| LANG: en_US.UTF-8 | ||
| HOMEBREW_LOGS: ~/homebrew-logs | ||
| HOMEBREW_TEMP: ~/homebrew-temp | ||
| HOMEBREW_NO_AUTO_UPDATE: 1 |
There was a problem hiding this comment.
Need this as the CI image fo 10.2.0 is on MacOS 10.14.3. However, brew now required 10.14.4 to build packages such as swiftlint. This should be fixed on Circle CI side at some point in the near future when they upgrade base image to 10.14.4
| @@ -54,7 +54,7 @@ Pod::Spec.new do |s| | |||
| s.social_media_url = 'https://twitter.com/auth0' | |||
|
|
|||
| s.ios.deployment_target = '9.0' | |||
| s.osx.deployment_target = '10.10' | |||
| s.osx.deployment_target = '10.11' | |||
There was a problem hiding this comment.
current macOS 10.14, 10.10 was release October 16, 2014
Related to #269, this is a potential BC, although should be minimal impact.
| @@ -38,7 +38,7 @@ class ResponseSpec: QuickSpec { | |||
|
|
|||
| it("should handle HTTP 204 responses") { | |||
| let response = Response<AuthenticationError>(data: nil, response: http(204), error: nil) | |||
| expect(try? response.result()).toNot(beNil()) | |||
| expect(try! response.result()).to(beNil()) | |||
There was a problem hiding this comment.
This one is a bit stranger and same for below, following the code the result should be Nil although there appears to be a difference in expectation between Swift 4.2 and 5.0 so forced try to ensure Nil vs
Cartfile
Outdated
| @@ -1 +1 @@ | |||
| github "auth0/SimpleKeychain" | |||
| github "auth0/SimpleKeychain" "update-swift5-xcode10.2" | |||
There was a problem hiding this comment.
Temp branch as other code not merged yet.
| github "Quick/Quick" ~> 1.3 | ||
| github "Quick/Nimble" ~> 7.1 | ||
| github "AliSoftware/OHHTTPStubs" ~> 6.1 | ||
| github "Quick/Quick" ~> 2.1 |
There was a problem hiding this comment.
Need new majors for Swift 5 compatibility, although these now drop Swift 3 and ObjC support in testing.
| @@ -5,6 +5,8 @@ coverage: | |||
| ignore: | |||
| - Auth0Tests/* | |||
| - App/* | |||
| - Auth0/_ObjectiveWebAuth.swift | |||
There was a problem hiding this comment.
Removed the codecov as the tests can't be run for the ObjC code in Quick/Nimble now.
cocojoe
changed the title
Changes
Update macOS to 10.11
Update Test dependencies Swift 5
Fix Warnings
Removed ObjC Testing
Update Readme
Update Fastlane
PodSpec Minimum versions align with Xcode
Testing
Added CI test for Swift 5.0
Checklist