Remove parameters from Authentication API client methods [SDK-2902]
#530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
changed the title
parameters param from Auth API client methods [SDK-2902]parameters param from Authentication API client methods [SDK-2902]
Widcket
changed the title
parameters param from Authentication API client methods [SDK-2902]parameters from Authentication API client methods [SDK-2902]
Widcket
force-pushed
the
v2/remove-parameters
branch
from
48067b1
to
9beec35
Compare
Widcket
commented
Nov 3, 2021
| @@ -1278,8 +1264,6 @@ public extension Authentication { | |||
| .start { print($0) } | |||
| ``` | |||
|
|
|||
| - precondition: if you are not using OAuth 2.0 API Authorization please use `delegation(parameters:)` | |||
There was a problem hiding this comment.
delegation(parameters:) is deprecated and will be removed in a future PR.
Widcket
force-pushed
the
v2/remove-parameters
branch
from
7119c05
to
b740533
Compare
Widcket
commented
Nov 3, 2021
| @@ -686,7 +678,7 @@ public protocol Authentication: Trackable, Loggable { | |||
|
|
|||
| /** | |||
| Renew user's credentials with a refresh_token grant for `/oauth/token` | |||
| If you are not using OAuth 2.0 API Authorization please use `delegation(parameters:)` | |||
There was a problem hiding this comment.
delegation(parameters:) is deprecated and will be removed in a future PR.
adamjmcgrath
approved these changes
Nov 4, 2021
|
|
||
| ``` | ||
| Auth0 | ||
| .authentication(clientId: clientId, domain: "samples.auth0.com") | ||
| .login(phoneNumber: "+4599134762367", | ||
| code: "123456", | ||
| audience: "https://myapi.com/api", | ||
| scope: "openid email", |
There was a problem hiding this comment.
For a later PR, but make sure you have instructions somewhere for adding custom params to /authorize
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The following Authentication API Client methods lost the
parametersparameter:login(phoneNumber:code:audience:scope:)login(usernameOrEmail:password:realm:audience:scope:)loginDefaultDirectory(withUsername:password:audience:scope:)tokenExchange()That parameter was no longer necessary since
Requesthas aparameters()method that can be used to pass custom parameters to any Authentication API Client method.Testing
Checklist