Remove remaining parameters parameter
#607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
commented
Dec 21, 2021
| @@ -631,12 +631,8 @@ public extension Authentication { | |||
| return self.signup(email: email, username: username, password: password, connection: connection, userMetadata: userMetadata, rootAttributes: rootAttributes) | |||
| } | |||
|
|
|||
| func signup(email: String, username: String? = nil, password: String, connection: String, userMetadata: [String: Any]? = nil) -> Request<DatabaseUser, AuthenticationError> { | |||
There was a problem hiding this comment.
This overload is not necessary because there is one above that adds default values to all the optional params. This one was adding default values to all but one. But in Swift you can omit a parameter if it has a default value (as per the overload above). So this one is pointless.
adamjmcgrath
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In the PR that removed the
parametersparameter across the SDK, the one in the methodstartPasswordless(email:type:connection:)from the Authentication API client was skipped because that method had some conditional logic for sending those parameters. But since theRequest.parametersmethod allows adding arbitrary parameters to any request (even that one), that logic does not hold anymore. So this PR removes the last remainingparametersparameter from thestartPasswordless(email:type:connection:)method.References
See #530
Testing
Checklist