Add canRenew() to the Credentials Manager
#723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
previously approved these changes
Jul 22, 2022
stevehobbsdev
approved these changes
Jul 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
This PR adds the method
canRenew()to the Credentials Manager, ashasValid()does not check for the presence of the refresh token (because the presence of the refresh token does not mean that there are valid credentials stored).This is only a problem when using biometric auth, because otherwise the developer can simply call
credentials()and check for thenoCredentialserror. If biometric auth is enabled, this check will trigger a biometric prompt.🎯 Testing
Besides unit tests, the changes were tested manually with an iPhone simulator running iOS 15.5 using Xcode 13.4.1 (13F100).