Expose error when storing renewed credentials fails #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
approved these changes
Jul 22, 2022
Widcket
added a commit
that referenced
this pull request
Jul 22, 2022
* Add `canRenew()` to the CredentialsManager * Expose error when storing renewed credentials fails (#724)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
Currently, if the Credentials Manager fails to store newly obtained credentials (after a renewal), this failure is silent and is not exposed to the developer:
This can be a problem when Refresh Token Rotation is enabled, because the new refresh token will not be persisted and the next renewal will fail.
This PR exposes an error to the developer when the store operation (after a renewal) fails.
🎯 Testing
A couple of unit tests were added.