Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for validating the org_name claim [SDK-4414] #782

Merged
merged 5 commits into from
Jul 13, 2023

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jul 11, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

馃搵 Changes

This PR adds a new ID token claim validator, IDTokenOrgNameValidator, which is only used if the organization value passed on login does not start with org_ (meaning, it's not an organization ID). Otherwise, the existing IDTokenOrgIDValidator is used instead.

馃幆 Testing

Besides adding unit tests, the changes were tested manually using a simulator running iOS 17.0, with Xcode 14.3 (14E222b).

@Widcket Widcket added the review:medium Medium review label Jul 11, 2023
@Widcket Widcket requested a review from a team as a code owner July 11, 2023 22:56
@stevehobbsdev
Copy link

stevehobbsdev commented Jul 12, 2023

LGTM - anything we want to update in EXAMPLES.md around Organizations? e.g. the sample in there refers to YOUR_AUTH0_ORGANIZATION_ID specifically, I've seen others change similar examples to something like YOUR_AUTH0_ORGANIZATION_ID_OR_NAME.

@Widcket
Copy link
Contributor Author

Widcket commented Jul 12, 2023

@stevehobbsdev Good catch! Added it in e7263c3

@Widcket Widcket merged commit 2c89b61 into master Jul 13, 2023
6 checks passed
@Widcket Widcket deleted the feature/organization-name branch July 13, 2023 11:00
@Widcket Widcket mentioned this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:medium Medium review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants