This repository has been archived by the owner on Sep 15, 2022. It is now read-only.
Change store service to a provider #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 24, 2015 08:15
…ror when running bower install
…s on the current system
- possible values are 'localStorage', 'sessionStorage' and 'cookieStorage' - default store is 'localStorage' - fallback store is 'cookieStorage' when localStorage or sessionStorage are not available in the browser
add method setStore() to set the storage with the storeProvider
```js
angular.module('app', ['angular-storage'])
.config(function (storeProvider) {
storeProvider.setStore('sessionStorage');
})
.controller('ctrl', function(store) {
store.set('name', 'wayne');
});
```
|
🔔 @mgonto 😉 |
|
Hey sorry bout the delay. It looks awesome :). Just 2 questions:
Thanks again for the PR! |
|
Did you run the gulp test-all task? It should use all browser found on your system. The plugin I can try to merge the normal karma config and the karma coverage config together. |
* makes karma-src.coverage.conf.js unnecessary
|
I removed the extra karma file for code coverage. Also you should consider adding travis so that all test run a each push/pull request to the repo. Just nice to have 😎 |
|
Now it looks awesome :). Thanks for the update :). Merging. I'll add Travis and release it later this week :). Thanks for all the hard work! |
mgonto
added a commit
that referenced
this pull request
Mar 16, 2015
Change store service to a provider
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sessionStoragestorestoreProvider.setStore()or set it instore.getNamespacedStore()gulp lintgulp cover