custom config tokenName in default tokenGetter #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed: use custom config tokenName in default tokenGetter method auth0#207
|
I don't suppose you could add a test for this? |
|
@escardin Excuse my I added amendments according to code style used in same method and I don't suppose you have test for that what is already in the code above: angular2-jwt.ts:54-60 |
|
The style is fine, I just want a test confirming behaviour. I would add something to the AuthConfig Closure here https://github.com/auth0/angular2-jwt/blob/master/angular2-jwt.spec.ts#L10-L48 You could confirm that the issue is fixed by setting a token in local storage with the id you want and that it is fetched by calling the token getter when you haven't modified it. |
|
@escardin sorry for misunderstanding. I have added the test. |
escardin
approved these changes
Dec 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: use custom config tokenName in default tokenGetter method #207