Restore pre 5.1.1 behavior and fix types #759
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Release v5.1.1 changed the code in such a way that calling
decodeToken('')
would call thetokenGetter
, while previously it would return null.Same for
isTokenExpired('')
, which used to return false, while in 5.1.1 it invokes the tokenGetter. AndgetTokenExpirationDate
, which used to returnnull
, is also calling the tokenGetter in 5.1.1.The PR reverts that behavior to restore it to the behavior it had pre-5.1.1.
On top of that, this PR is also fixing the types to ensure the following types are correct:
Added tests to ensure the above using
tsd
.I have also added additional tests to cover for the behavior that got broken in 5.1.1.
Checklist