-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable strict mode #123
Enable strict mode #123
Conversation
Thanks for this PR, we always appreciate contributions like this. As this includes a breaking change, we will need to consider how and if we want to include this.
or
I am a big fan of using TypeScript strict mode, but if it is the only reason for introducing a breaking change, I am not sure I am keen on doing so. I will keep this PR open, as I want to discuss this with our team as well. But keep in mind this isn't a priority for us at the moment, especially given the breaking change it introduces. |
In
This would not change method API. So, as I understand, it would not be a breaking change |
add options in tsconfig Fix type errors + add generics
7e5b83a
to
291d272
Compare
Description
Enable strict TS options.
Set them to the same values that Angular sets during creating a new project via
ng new
.I fixed new type errors + add generics for better type checking
References
https://blog.angular.io/angular-cli-strict-mode-c94ba5965f63
https://angular.io/guide/strict-mode
Checklist
master