DXCDT-331: Fix how we check if we should prompt when no flags set on cmd invocation #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Sadly, a regression was introduced through #563, where we moved the
--jsonflag from a global flag to a local flag. This caused the oldshouldPromptWhenNoLocalFlagsSet()func to miss behave and incorrectly skip prompting for flag values to be set in interactive mode when just the--jsonflag was present (e.g.auth0 ap bpd update --json). This PR addresses this and as well includes a check for the--forceflag as that was removed from the global level as well in a subsequent PR.📚 References
🔬 Testing
📝 Checklist